lkml.org 
[lkml]   [2023]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drivers: nvdimm: fix possible memory leak
    Date
    Memory pointed by 'nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs[0]'
    is allocated in function 'nvdimm_pmu_cpu_hotplug_init' via
    'create_cpumask_attr_group' call. But not released in function
    'nvdimm_pmu_free_hotplug_memory' or anywhere else before memory pointed by
    'nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs' will be freed.

    Fixes: 0fab1ba6ad6b ("drivers/nvdimm: Add perf interface to expose nvdimm performance stats")
    Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
    Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
    ---
    drivers/nvdimm/nd_perf.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
    index 2b6dc80d8..ecfa1f635 100644
    --- a/drivers/nvdimm/nd_perf.c
    +++ b/drivers/nvdimm/nd_perf.c
    @@ -264,10 +264,14 @@ static void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
    {
    cpuhp_state_remove_instance_nocalls(nd_pmu->cpuhp_state, &nd_pmu->node);
    cpuhp_remove_multi_state(nd_pmu->cpuhp_state);

    - if (nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR])
    + if (nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]) {
    + if (nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs)
    + kfree(nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs[0]);
    +
    kfree(nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs);
    + }
    kfree(nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]);
    }

    int register_nvdimm_pmu(struct nvdimm_pmu *nd_pmu, struct platform_device *pdev)
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-09-05 19:10    [W:2.067 / U:0.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site