Messages in this thread | | | Date | Tue, 5 Sep 2023 13:25:37 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 1/4] sched: consolidate and cleanup access to CPU's max compute capacity |
| |
On Fri, Sep 01, 2023 at 03:03:09PM +0200, Vincent Guittot wrote: > Remove struct rq cpu_capacity_orig field and use arch_scale_cpu_capacity() > instead. > > Scheduler uses 3 methods to get access to the CPU's max compute capacity: > - arch_scale_cpu_capacity(cpu) which is the default way to get CPU's capacity. > - cpu_capacity_orig field which is periodically updated with > arch_scale_cpu_capacity(). > - capacity_orig_of(cpu) which encapsulates rq->cpu_capacity_orig > > There is no real need to save the value returned by arch_scale_cpu_capacity() > in struct rq. arch_scale_cpu_capacity() returns: > - either a per_cpu variable. > - or a const value for systems which have only one capacity. > > Remove cpu_capacity_orig and use arch_scale_cpu_capacity() everywhere. > > No functional changes.
I think the original thinking was that we wouldn't know how expensive the function call would end up being, but yeah, given how things stand this is a nice cleanup.
| |