Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v4 04/10] net/socket: Break down __sys_getsockopt | Date | Tue, 5 Sep 2023 09:36:34 +0000 |
| |
From: Breno Leitao > Sent: 04 September 2023 17:25 > > Split __sys_getsockopt() into two functions by removing the core > logic into a sub-function (do_sock_getsockopt()). This will avoid > code duplication when doing the same operation in other callers, for > instance.
Although a lot more work, I think (others may disagree) that the internal getsockopt() functions should be changed to take the length as a parameter and return the positive value to write back.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |