Messages in this thread | | | Date | Tue, 5 Sep 2023 11:54:37 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH] Revert "printk: export symbols for debug modules" |
| |
Added people from the original thread into Cc.
On Tue 2023-09-05 10:19:02, Christoph Hellwig wrote: > This reverts commit 3e00123a13d824d63072b1824c9da59cd78356d9. > > No, we never export random symbols for out of tree modules.
Yeah, I did not have a good feeling about this patch.
I accepted it because there was an intention to upstream the module, see https://lore.kernel.org/all/CAAfh-jM0B2Cn579B0CkCrW44pJGGvjs112K+oMuViib+jDKafg@mail.gmail.com/
I think that it was bad decision. We should not export symbols when there is no in-tree user.
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |