lkml.org 
[lkml]   [2023]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Revert "printk: export symbols for debug modules"
Added people from the original thread into Cc.

On Tue 2023-09-05 10:19:02, Christoph Hellwig wrote:
> This reverts commit 3e00123a13d824d63072b1824c9da59cd78356d9.
>
> No, we never export random symbols for out of tree modules.

Yeah, I did not have a good feeling about this patch.

I accepted it because there was an intention to upstream
the module, see
https://lore.kernel.org/all/CAAfh-jM0B2Cn579B0CkCrW44pJGGvjs112K+oMuViib+jDKafg@mail.gmail.com/

I think that it was bad decision. We should not export
symbols when there is no in-tree user.

> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

\
 
 \ /
  Last update: 2023-09-05 18:43    [W:0.461 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site