Messages in this thread | | | Date | Tue, 5 Sep 2023 13:15:26 +0200 | From | Simon Horman <> | Subject | Re: [PATCH] net: dsa: mt7530: refactor deprecated strncpy |
| |
On Tue, Sep 05, 2023 at 09:46:14AM +0530, Shubh wrote: > Prefer `strscpy_pad` to `strncpy`.
I think this needs some justification. Why is strscpy_pad() preferred in this case?
Also, assuming this is not a bug-fix for 'net', then it is an enhancement, and should be targeted at net-next.
Subject: [PATCH net-next] ...
As it stands, net-next is closed:
## Form letter - net-next-closed
The merge window for v6.6 has begun and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only.
Please repost when net-next reopens after Sept 11th.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
> > Signed-off-by: Shubh <shubhisroking@gmail.com> > --- > drivers/net/dsa/mt7530.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 035a34b50..ee19475ec 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -836,7 +836,7 @@ mt7530_get_strings(struct dsa_switch *ds, int port, u32 stringset, > return; > > for (i = 0; i < ARRAY_SIZE(mt7530_mib); i++) > - strncpy(data + i * ETH_GSTRING_LEN, mt7530_mib[i].name, > + strscpy_pad(data + i * ETH_GSTRING_LEN, mt7530_mib[i].name, > ETH_GSTRING_LEN);
The line above is no longer indented correctly.
> }
-- pw-bot: defer
| |