Messages in this thread | | | Date | Tue, 5 Sep 2023 09:37:58 +0000 | From | Charles Keepax <> | Subject | Re: [PATCH 8/9] ASoC: cs35l41: Use modern pm_ops |
| |
On Sun, Sep 03, 2023 at 12:06:20AM +0300, Cristian Ciocaltea wrote: > Make use of the recently introduced EXPORT_GPL_DEV_PM_OPS() macro, to > conditionally export the runtime/system PM functions. > > Replace the old SET_{RUNTIME,SYSTEM_SLEEP,NOIRQ_SYSTEM_SLEEP}_PM_OPS() > helpers with their modern alternatives and get rid of the now > unnecessary '__maybe_unused' annotations on all PM functions. > > Additionally, use the pm_ptr() macro to fix the following errors when > building with CONFIG_PM disabled: > > ERROR: modpost: "cs35l41_pm_ops" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined! > ERROR: modpost: "cs35l41_pm_ops" [sound/soc/codecs/snd-soc-cs35l41-i2c.ko] undefined! > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks, Charles
| |