Messages in this thread | | | Date | Wed, 6 Sep 2023 01:10:44 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH 4/8] i2c: sprd: Add IIC controller driver to support dynamic switching of 400K/1M/3.4M frequency |
| |
Hi Chunyan,
> > > > #define SPRD_I2C_PM_TIMEOUT 1000 > > > > /* timeout (ms) for transfer message */ > > > > #define I2C_XFER_TIMEOUT 1000 > > > > - > > > > +/* dynamic modify clk_freq flag */ > > > > +#define I2C_3M4_FLAG 0x0100 > > > > > > #define <space> I2C_3M4_FLAG <tab> 0x0100 > > > > > > > +#define I2C_1M_FLAG 0x0080 > > > > +#define I2C_400K_FLAG 0x0040 > > > > + > > > > +#define I2C_FREQ_400K 400000 > > > > +#define I2C_FREQ_1M 1000000 > > > > +#define I2C_FREQ_3_4M 3400000 > > > > > > ditto > > I meant "#define <space> I2C_FREQ_3_4M <tab> 3400000"
right! Agree with your comment!
> > > > why should he use IIC instead of I2C. The file's defines start > > with I2C, for consistency he should use the same prefix. > > > > Yes, I agree.
Thanks, Andi
| |