Messages in this thread | | | Date | Wed, 6 Sep 2023 00:52:21 +0300 | Subject | Re: [RFT PATCH 2/2] arm64: dts: qcom: msm8996-xiaomi: fix missing clock populate | From | Dmitry Baryshkov <> |
| |
On 01/09/2023 11:18, Krzysztof Kozlowski wrote: > Commit 338958e30c68 ("arm64: dts: qcom: msm8996-xiaomi: drop simple-bus > from clocks") removed "simple-bus" compatible from "clocks" node, but > one of the clocks - divclk1 - is a gpio-gate-clock, which does not have > CLK_OF_DECLARE. This means it will not be instantiated if placed in > some subnode. Move the clocks to the root node, so regular devices will > be populated. > > Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Closes: https://lore.kernel.org/all/CAA8EJprF==p87oN+RiwAiNeURF1JcHGfL2Ez5zxqYPRRbN-hhg@mail.gmail.com/ > Cc: <stable@vger.kernel.org> > Fixes: 338958e30c68 ("arm64: dts: qcom: msm8996-xiaomi: drop simple-bus from clocks") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 32 +++++++++---------- > .../boot/dts/qcom/msm8996-xiaomi-gemini.dts | 16 ++++------ > 2 files changed, 22 insertions(+), 26 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |