lkml.org 
[lkml]   [2023]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI: xgene-msi: Fix a potential UAF in xgene_msi_probe
> On Tue, 26 Sep 2023 03:59:36 +0100,
> Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
> >
> > xgene_allocate_domains() will call irq_domain_remove() to free
> > msi->inner_domain on failure. However, its caller, xgene_msi_probe(),
> > will also call irq_domain_remove() through xgene_msi_remove() on the
> > same failure, which may lead to a use-after-free. Remove the first
> > irq_domain_remove() and let xgene_free_domains() cleanup domains.
> >
> > Fixes: dcd19de36775 ("PCI: xgene: Add APM X-Gene v1 PCIe MSI/MSIX termination driver")
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
> >
> > Changelog:
> >
> > v2: -Remove irq_domain_remove() instead of nulling msi_domain.
>
> Unfortunately, your email doesn't indicate this is v2.

Sorry, my mistake. I will resend a new patch soon.

Regards,
Dinghao
\
 
 \ /
  Last update: 2023-09-30 11:58    [W:0.084 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site