lkml.org 
[lkml]   [2023]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] rust: bindings: rename const binding using sed
    From
    On 9/30/23 10:36, Gary Guo wrote:
    > Current for consts that bindgen don't recognise, we define a helper
    > constant with
    >
    > const <TYPE> BINDINGS_<NAME> = <NAME>;
    >
    > in `bindings_helper.h` and then we put
    >
    > pub const <NAME>: <TYPE> = BINDINGS_<NAME>;
    >
    > in `bindings/lib.rs`. This is fine that we currently only have 3
    > constants that are defined this way, but is going to be more annoying
    > when more constants are added since every new constant needs to be
    > defined in two places.
    >
    > This patch changes the way we define constant helpers to
    >
    > const <TYPE> RUST_BINDING_<NAME> = <NAME>;
    >
    > and then use `sed` to postprocess Rust code by generated by bindgen to
    > remove the distinct prefix, so user of the binding crate can refer to
    > the name directly.
    >
    > Signed-off-by: Gary Guo <gary@garyguo.net>
    > ---
    > [...]
    This one is a must have.

    Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>

    \
     
     \ /
      Last update: 2023-10-01 01:40    [W:4.573 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site