Messages in this thread | | | Subject | Re: [PATCH 1/3] hugetlbfs: extend hugetlb_vma_lock to private VMAs | From | Rik van Riel <> | Date | Sat, 30 Sep 2023 15:48:20 -0400 |
| |
On Fri, 2023-09-29 at 19:28 -0700, Mike Kravetz wrote: > On 09/25/23 23:10, riel@surriel.com wrote: > > > In reply to patch 1, I suggested the changes: > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index f906c5fa4d09..8f3d5895fffc 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -372,6 +372,11 @@ static void > > __hugetlb_vma_unlock_write_free(struct vm_area_struct *vma) > > struct hugetlb_vma_lock *vma_lock = vma- > > >vm_private_data; > > > > __hugetlb_vma_unlock_write_put(vma_lock); > > + } else if (__vma_private_lock(vma)) { > > + struct resv_map *resv_map = vma_resv_map(vma); > > + > > + /* no free for anon vmas, but still need to unlock > > */ > > + up_write(&resv_map->rw_sema); > > } > > } > > However, the check for 'if (__vma_private_lock(vma))' was dropped.
Oh ugh. I definitely added that in somewhere, but must have committed that to the wrong git branch :(
Let me send out a new version with that change.
Sorry about that.
-- All Rights Reversed.
| |