lkml.org 
[lkml]   [2023]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] rust: add Soft-RoCE driver basic structure
On Sat, Sep 30, 2023 at 12:32 PM AllenX <xubo3006@163.com> wrote:
>
> add soft-Roce rxe device net driver basic structure and Rust security abstration interface

It looks like your patch hit the list twice, see [1] and [2]. Also,
the body should be hard wrapped [3].

Since it's usually the first thing to be asked, do you have a
real-world driver that this is intended for? Typically new
abstractions don't get merged upstream unless there is an in-tree use
case.

We can still give the patch a cursory review from the Rust side even
if it isn't meant for upstreaming as-is. For future reference, you can
have "RFC PATCH" in the subject to make this clear (`git format-patch
--rfc` does this)

[1]: https://lore.kernel.org/rust-for-linux/20230930163256.60779-1-xubo3006@163.com/
[2]: https://lore.kernel.org/rust-for-linux/20230930161443.58812-1-xubo3006@163.com/
[3]: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format

\
 
 \ /
  Last update: 2023-09-30 19:47    [W:0.077 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site