Messages in this thread | | | Date | Sat, 30 Sep 2023 17:54:51 +0200 | Subject | Re: [PATCH v2 3/3] usb: chipidea: Add support for NPCM | From | Krzysztof Kozlowski <> |
| |
On 27/09/2023 11:55, Tomer Maimon wrote: > Add Nuvoton NPCM BMC SoCs support to USB ChipIdea driver. > NPCM SoC include ChipIdea IP block that used for USB device controller > mode.
...
> + ci = devm_kzalloc(&pdev->dev, sizeof(*ci), GFP_KERNEL); > + if (!ci) > + return -ENOMEM; > + platform_set_drvdata(pdev, ci); > + > + ci->core_clk = devm_clk_get_optional(dev, NULL); > + if (IS_ERR(ci->core_clk)) > + return PTR_ERR(ci->core_clk); > + > + ret = clk_prepare_enable(ci->core_clk); > + if (ret) { > + dev_err(dev, "failed to enable the clock: %d\n", ret); > + return ret;
return dev_err_probe()
...
> + > +module_platform_driver(npcm_udc_driver); > + > +MODULE_DESCRIPTION("NPCM USB device controller driver"); > +MODULE_AUTHOR("Tomer Maimon <tomer.maimon@nuvoton.com>"); > +MODULE_ALIAS("platform:npcm-udc");
Nope... if you need it, your tables are wrong.
Best regards, Krzysztof
| |