Messages in this thread | | | Date | Sun, 3 Sep 2023 17:56:36 +0530 | Subject | Re: [PATCH net-next 0/2] net: qrtr: Few qrtr fixes | From | Sricharan Ramabadhran <> |
| |
Hi Simon,
On 9/1/2023 7:49 PM, Simon Horman wrote: > On Fri, Sep 01, 2023 at 03:50:19PM +0530, Sricharan Ramabadhran wrote: >> Patch #1 fixes a race condition between qrtr driver and ns opening and >> sending data to a control port. >> >> Patch #2 address the issue with legacy targets sending the SSR >> notifications using DEL_PROC control message. > > Hi Sricharan, > > if these are fixes then they should be targeted at 'net' rather than > 'net-next', and consideration should be given to supplying Fixes tags. > There is as such no existing feature broken without these 2 patches today. Then they might qualify as preparatory patches for adding some features.
> If these are not fixes, then please don't describe them as such. > In this case targeting net-next is correct, but it is currently closed, > as per the form letter below. > Sure, then in that case looks like it belongs to 'net-next' and will post V2 once the net-next is opened again.
> In either case please consider: > > * Arranging local variables for new Networking code in > reverse xmas tree order - longest line to shortest > > * Avoiding introducing new Sparse warnings > > ok.
> ## Form letter - net-next-closed > > The merge window for v6.6 has begun and therefore net-next is closed > for new drivers, features, code refactoring and optimizations. > We are currently accepting bug fixes only. > > Please repost when net-next reopens after Sept 11th. >
ok, sure.
Regards, Sricharan
| |