Messages in this thread | | | Date | Sun, 3 Sep 2023 11:55:20 +0200 | From | Willy Tarreau <> | Subject | Re: [RFC PATCH v3 2/4] tools/nolibc: x86-64: Use `rep stosb` for `memset()` |
| |
On Sun, Sep 03, 2023 at 03:39:33PM +0700, Ammar Faizi wrote: > [ Resend, I sent it using the wrong From address. ] > > On 2023/09/03 ??3:17, Willy Tarreau wrote: > > On Sun, Sep 03, 2023 at 02:34:22AM +0700, Ammar Faizi wrote: > > > On Sun, Sep 03, 2023 at 02:28:18AM +0700, Alviro Iskandar Setiawan wrote: > > > > nit: Be consistent. Use \n\t for the memset too. > > > > > > Good catch, I'll fix that in v4 revision. > > > > Ammar, I'm overall fine with your series. I can as well add the missing \t > > to your patch while merging it, or wait for your v4, just let me know. > > I'm now traveling and will be available in Jakarta on Monday. Thus, I > actually planned to send the v4 revision on Monday. > > However, since you don't have further objections to this series, I'll > leave the trivial missing bit to you. Please merge this series and I > will not send a v4 revision.
OK now merged with the \t appended. No need to spend your time on a v4 anymore.
Thanks! Willy
| |