lkml.org 
[lkml]   [2023]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Staging: Fixed some formatting warnings in the vme_user driver
Ok, thanks mate, appreciate that. I'll check it out and give it
another whirl (assuming the rest of the talk is still valid ... and
you guys still want these sorts of patches!)
Cheers
JB


On Sun, Sep 3, 2023 at 11:40 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Sep 03, 2023 at 11:17:41AM +0200, Jonathan Bergh wrote:
> > Hi Greg,
> > I hope you are well. I got this response from your bot!
> > I pretty much followed your FOSDEM instructions for *first kernel
> > patches* so i thought I was doing it right.
>
> That's a really old talk, things have changed a bit since then :)
>
> > Based on the video of your talk, is more required in the SUBJECT and
> > BODY for such a (basic) change? It seemed the above was pretty much
> > inline with the terseness / examples you showed in your presentation.
> > Hopefully thats the case.
>
> Yes, you need a better changelog and subject line. Read the link that
> the bot referred you to and look at all of the examples commits that
> have been accepted for the files that you modified to give you an idea
> of what is needed.
>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2023-09-03 11:55    [W:0.042 / U:3.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site