Messages in this thread | | | From | Jonathan Bergh <> | Date | Sun, 3 Sep 2023 21:42:49 +0200 | Subject | Re: [PATCH] staging: vme_user: Add missing '*' in multiline comments |
| |
Yes ... that would be better.
On Sun, Sep 3, 2023 at 4:43 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Sun, Sep 03, 2023 at 04:06:17PM +0200, Jonathan Bergh wrote: > > This patch resolves a warning reported by checkpatch where multiline > > block comments should use '*' on intermediate lines in order to adhere > > to the Linux kernel coding-style guidelines. > > > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> > > --- > > drivers/staging/vme_user/vme_fake.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c > > index 7c53a8a7b79b..90aaf650524d 100644 > > --- a/drivers/staging/vme_user/vme_fake.c > > +++ b/drivers/staging/vme_user/vme_fake.c > > @@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size, > > { > > kfree(vaddr); > > /* > > - dma_free_coherent(parent, size, vaddr, dma); > > -*/ > > + * dma_free_coherent(parent, size, vaddr, dma); > > + */ > > As this code isn't being used, why not just delete it instead? > > thanks, > > greg k-h
| |