lkml.org 
[lkml]   [2023]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v16 09/20] drm/shmem-helper: Remove obsoleted is_iomem test
    Date
    Everything that uses the mapped buffer should be agnostic to is_iomem.
    The only reason for the is_iomem test is that we're setting shmem->vaddr
    to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove
    the obsoleted is_iomem test to clean up the code.

    Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
    Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
    ---
    drivers/gpu/drm/drm_gem_shmem_helper.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
    index 2b50d1a7f718..25e99468ced2 100644
    --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
    +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
    @@ -317,12 +317,6 @@ int drm_gem_shmem_vmap_locked(struct drm_gem_shmem_object *shmem,

    if (obj->import_attach) {
    ret = dma_buf_vmap(obj->import_attach->dmabuf, map);
    - if (!ret) {
    - if (drm_WARN_ON(obj->dev, map->is_iomem)) {
    - dma_buf_vunmap(obj->import_attach->dmabuf, map);
    - return -EIO;
    - }
    - }
    } else {
    pgprot_t prot = PAGE_KERNEL;

    --
    2.41.0
    \
     
     \ /
      Last update: 2023-09-03 19:10    [W:5.486 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site