Messages in this thread | | | From | Kees Cook <> | Subject | Re: [PATCH] x86/tdx: refactor deprecated strncpy | Date | Fri, 29 Sep 2023 11:33:46 -0700 |
| |
On Mon, 11 Sep 2023 18:27:25 +0000, Justin Stitt wrote: > `strncpy` is deprecated and we should prefer more robust string apis. > > In this case, `message.str` is not expected to be NUL-terminated as it > is simply a buffer of characters residing in a union which allows for > named fields representing 8 bytes each. There is only one caller of > `tdx_panic()` and they use a 59-length string for `msg`: > | const char *msg = "TD misconfiguration: SEPT_VE_DISABLE attribute must be set."; > > [...]
This appears to be trivially correct, so I can take it via my tree.
Applied to for-next/hardening, thanks!
[1/1] x86/tdx: refactor deprecated strncpy https://git.kernel.org/kees/c/e32c46753312
Take care,
-- Kees Cook
| |