Messages in this thread | | | Date | Fri, 29 Sep 2023 08:39:42 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 6/6] serial: imx: do not set RS485 enabled if it is not supported |
| |
On Fri, Sep 29, 2023 at 12:12:46AM +0200, Lino Sanfilippo wrote: > From: Lino Sanfilippo <l.sanfilippo@kunbus.com> > > If the imx driver cannot support RS485 it sets the UARTS rs485_supported > structure to NULL. But it still calls uart_get_rs485_mode() which may set > the RS485_ENABLED flag. > The flag however is evaluated by the serial core in uart_configure_port()
I wonder if this is the code location where this problem should be addressed. Or alternatively don't let uart_get_rs485_mode() set RS485_ENABLED (and other flags) if rs485_supported doesn't suggest that this works?
> [...] > > Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
I don't know how picky Greg is here, but formally you missed to add an S-o-b line for the sender of this patch (i.e. you with your gmx address).
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |