Messages in this thread Patch in this message | | | From | Subbaraya Sundeep Bhatta <> | Subject | RE: [EXT] [PATCH net-next v6 05/10] octeontx2-pf: mcs: update PN only when update_pn is true | Date | Fri, 29 Sep 2023 06:20:05 +0000 |
| |
Hi,
>-----Original Message----- >From: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com> >Sent: Thursday, September 28, 2023 2:14 PM >To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula ><gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; >Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net; >edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >borisp@nvidia.com; saeedm@nvidia.com; leon@kernel.org; sd@queasysnail.net; >andrew@lunn.ch; hkallweit1@gmail.com; linux@armlinux.org.uk; >richardcochran@gmail.com; sebastian.tobuschat@oss.nxp.com >Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linux- >rdma@vger.kernel.org; Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com> >Subject: [EXT] [PATCH net-next v6 05/10] octeontx2-pf: mcs: update PN only >when update_pn is true > >When updating SA, update the PN only when the update_pn flag is true. >Otherwise, the PN will be reset to its previous value. > >Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com> >--- >Changes in v6: >- patch added in v6 > > drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c >b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c >index 59b138214af2..4c59850dfddf 100644 >--- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c >+++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c >@@ -1362,6 +1362,9 @@ static int cn10k_mdo_upd_txsa(struct macsec_context >*ctx) > if (err) > return err; > >+ if (!ctx->sa.update_pn) >+ return 0; >+ This is incorrect. Please change it as below:
@@ -1357,10 +1357,12 @@ static int cn10k_mdo_upd_txsa(struct macsec_context *ctx)
if (netif_running(secy->netdev)) { /* Keys cannot be changed after creation */ - err = cn10k_write_tx_sa_pn(pfvf, txsc, sa_num, - sw_tx_sa->next_pn); - if (err) - return err; + if (ctx->sa.update_pn) { + err = cn10k_write_tx_sa_pn(pfvf, txsc, sa_num, + sw_tx_sa->next_pn); + if (err) + return err; + }
err = cn10k_mcs_link_tx_sa2sc(pfvf, secy, txsc, sa_num, sw_tx_sa->active);
> err = cn10k_mcs_link_tx_sa2sc(pfvf, secy, txsc, > sa_num, sw_tx_sa->active); > if (err) >@@ -1529,6 +1532,9 @@ static int cn10k_mdo_upd_rxsa(struct macsec_context >*ctx) > if (err) > return err; > >+ if (!ctx->sa.update_pn) >+ return 0; >+ This is correct.
Thanks, Sundeep > err = cn10k_mcs_write_rx_sa_pn(pfvf, rxsc, sa_num, > rx_sa->next_pn); > if (err) >-- >2.34.1
| |