lkml.org 
[lkml]   [2023]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions
On Fri, Sep 29, 2023 at 03:26:17PM +0300, Dan Carpenter wrote:
> On Fri, Sep 29, 2023 at 09:23:26AM +0200, Christian Lamparter wrote:
> > I would like to take the chance to again point to this beauty:
> > <https://lore.kernel.org/linux-wireless/TYAP286MB03154F9AAFD4C35BEEDE4A99BC4CA@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM/T/#mf1b8919a000fe661803c17073f48b3c410888541>
> > @Dan, @Jeff can you please comment on that too?
>
> I don't know how Shiji Yang generated this warning. The warning doesn't
> make sense and I don't see how the patch helps. I tested with GCC (v12)
> and Clang (random from git) and neither one generates a warning. What's
> the point of having all the struct members in a group when struct itself
> already forms a group?
>
> #confused

Wait, all this was in the email thread from June but I didn't scroll
down beyond the end of the patch... It was just a compiler bug in a
GCC dot release.

regards,
dan carpenter

\
 
 \ /
  Last update: 2023-09-29 14:34    [W:0.067 / U:1.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site