Messages in this thread | | | Date | Fri, 29 Sep 2023 20:32:59 +0900 | From | Masami Hiramatsu (Google) <> | Subject | Re: [PATCH] tracing/eprobe: drop unneeded breaks |
| |
On Thu, 28 Sep 2023 12:43:34 +0200 Julia Lawall <Julia.Lawall@inria.fr> wrote:
> Drop break after return. >
Good catch! This looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
And
Fixes: 7491e2c44278 ("tracing: Add a probe that attaches to trace events")
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> > > --- > kernel/trace/trace_eprobe.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c > index 72714cbf475c..03c851f57969 100644 > --- a/kernel/trace/trace_eprobe.c > +++ b/kernel/trace/trace_eprobe.c > @@ -788,12 +788,9 @@ find_and_get_event(const char *system, const char *event_name) > name = trace_event_name(tp_event); > if (!name || strcmp(event_name, name)) > continue; > - if (!trace_event_try_get_ref(tp_event)) { > + if (!trace_event_try_get_ref(tp_event)) > return NULL; > - break; > - } > return tp_event; > - break; > } > return NULL; > } >
-- Masami Hiramatsu (Google) <mhiramat@kernel.org>
| |