Messages in this thread | | | Date | Fri, 29 Sep 2023 14:26:53 +0530 | Subject | Re: [PATCH V12 2/3] dt-bindings: pwm: add IPQ6018 binding | From | Devi Priya <> |
| |
On 9/29/2023 1:25 PM, Devi Priya wrote: > > > On 9/25/2023 12:41 PM, Krzysztof Kozlowski wrote: >> On 25/09/2023 08:59, Devi Priya wrote: >>> DT binding for the PWM block in Qualcomm IPQ6018 SoC. >>> >>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> >>> Co-developed-by: Baruch Siach <baruch.siach@siklu.com> >>> Signed-off-by: Baruch Siach <baruch.siach@siklu.com> >>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >> >> ... >> >>> diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml >>> b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml >>> new file mode 100644 >>> index 000000000000..857086ad539e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml >> >> Filename matching compatible, so qcom,ipq6018-pwm.yaml > okay We would have other ipq compatibles (ipq9574 & ipq5332) being added to the binding in the upcoming series. So, shall we rename the binding to qcom,ipq-pwm.yaml
Thanks, Devi Priya >> >>> @@ -0,0 +1,53 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm IPQ6018 PWM controller >>> + >>> +maintainers: >>> + - Baruch Siach <baruch@tkos.co.il> >>> + >>> +properties: >>> + "#pwm-cells": >>> + const: 2 >>> + >>> + compatible: >>> + const: qcom,ipq6018-pwm >> >> compatible is always the first property. > okay >> >>> + >>> + reg: >>> + description: Offset of PWM register in the TCSR block. >>> + maxItems: 1 >>> + >>> + clocks: >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - clocks >>> + - "#pwm-cells" >> >> And this order must be the same as in properties. > okay >> >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include <dt-bindings/clock/qcom,gcc-ipq6018.h> >>> + >>> + syscon@1937000 { >>> + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd"; >>> + reg = <0x01937000 0x21000>; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges = <0 0x1937000 0x21000>; >> >> Drop this node, not related. The parent binding could have full example, >> on the other hand. Additionally, I have doubts that you really tested >> the parent binding. > Sure, will drop the syscon node > > Thanks, > Devi Priya >> >>> + >>> + pwm: pwm@a010 { >>> + compatible = "qcom,ipq6018-pwm"; >> >> Best regards, >> Krzysztof >>
| |