lkml.org 
[lkml]   [2023]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 4/4] soc: kunpeng_hccs: Migrate to use generic PCC shmem related macros
From
lgtm,
Reviewed-by: Huisong Li <lihuisong@huawei.com>


在 2023/9/28 0:26, Sudeep Holla 写道:
> Use the newly defined common and generic PCC shared memory region
> related macros in this driver to replace the locally defined ones.
>
> Cc: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/soc/hisilicon/kunpeng_hccs.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
> index f3810d9d1caa..27a96cafd1ea 100644
> --- a/drivers/soc/hisilicon/kunpeng_hccs.c
> +++ b/drivers/soc/hisilicon/kunpeng_hccs.c
> @@ -31,10 +31,6 @@
>
> #include "kunpeng_hccs.h"
>
> -/* PCC defines */
> -#define HCCS_PCC_SIGNATURE_MASK 0x50434300
> -#define HCCS_PCC_STATUS_CMD_COMPLETE BIT(0)
> -
> /*
> * Arbitrary retries in case the remote processor is slow to respond
> * to PCC commands
> @@ -187,7 +183,7 @@ static int hccs_check_chan_cmd_complete(struct hccs_dev *hdev)
> * deadline_us(timeout_us) until PCC command complete bit is set(cond)
> */
> ret = readw_poll_timeout(&comm_base->status, status,
> - status & HCCS_PCC_STATUS_CMD_COMPLETE,
> + status & PCC_STATUS_CMD_COMPLETE,
> HCCS_POLL_STATUS_TIME_INTERVAL_US,
> cl_info->deadline_us);
> if (unlikely(ret))
> @@ -208,7 +204,7 @@ static int hccs_pcc_cmd_send(struct hccs_dev *hdev, u8 cmd,
> int ret;
>
> /* Write signature for this subspace */
> - tmp.signature = HCCS_PCC_SIGNATURE_MASK | hdev->chan_id;
> + tmp.signature = PCC_SIGNATURE | hdev->chan_id;
> /* Write to the shared command region */
> tmp.command = cmd;
> /* Clear cmd complete bit */
>

\
 
 \ /
  Last update: 2023-09-28 13:31    [W:0.384 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site