lkml.org 
[lkml]   [2023]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 4/5] riscv: dts: renesas: rzfive-smarc: Drop dma properties from SSI1 node
    From
    Hi Prabhakar,

    On 2023-09-28 7:07 PM, Prabhakar wrote:
    > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    >
    > With DMA enabled audio capture/playback has some echo noise. So for
    > now switch to PIO mode until fixed.

    Is it really appropriate to work around a Linux software bug with a DT change
    like this? Remember, the devicetrees are used by software other than Linux.

    Regards,
    Samuel

    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > ---
    > arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    > diff --git a/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi b/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi
    > index a8573fdfd8b1..85f96e24a96e 100644
    > --- a/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi
    > +++ b/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi
    > @@ -6,3 +6,8 @@
    > */
    >
    > #include <arm64/renesas/rzg2ul-smarc.dtsi>
    > +
    > +&ssi1 {
    > + /delete-property/ dmas;
    > + /delete-property/ dma-names;
    > +};

    \
     
     \ /
      Last update: 2023-09-29 02:31    [W:3.060 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site