Messages in this thread | | | Date | Thu, 28 Sep 2023 23:17:23 +0200 | From | Ingo Molnar <> | Subject | Re: [GIT PULL] irqchip fixes for 6.6, take #1 |
| |
* Marc Zyngier <maz@kernel.org> wrote:
> Dmitry Baryshkov (1): > arm64: dts: qcom: sm8150: extend the size of the PDC resource
This SOB chain, while valid, is a hodgepodge with no rhyme and reason:
Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org
Besides the ordering, people in the SOB chain should not have a separate Reviewed-by tag: *of course* anyone who forwards a patch with a SOB has reviewed it, it's basically implicit.
So the tags should be something like:
Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Marc Zyngier <maz@kernel.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org
Ie. we generally sort the tags not chronologically (or whatever the original idea was), but group them topically, sort the groups by importance, and only within the group is there chronological order.
Thanks,
Ingo
| |