lkml.org 
[lkml]   [2023]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 3/8] x86/resctrl: Split the rdt_domain structure
From
Hi Tony,

On 9/28/2023 10:33 AM, Tony Luck wrote:
> On Mon, Sep 25, 2023 at 04:25:15PM -0700, Reinette Chatre wrote:
>>
>> On 8/29/2023 4:44 PM, Tony Luck wrote:

>>> Similar breakout of struct rdt_hw_mondomain from struct rdt_hw_domain.
>>
>> rdt_hw_mondomain and rdt_hw_ctrldomain?
>
> Yes. rdt_hw_domain is split two ways and each gets an appropriate name.
> I added an extra "_" to match shape of other names. So these are now
> "rdt_hw_ctrl_domain" and "rdt_hw_mon_domain"

Thank you for adding the extra "_", it looks good.

...

>>> @@ -641,12 +641,12 @@ void cqm_handle_limbo(struct work_struct *work)
>>> unsigned long delay = msecs_to_jiffies(CQM_LIMBOCHECK_INTERVAL);
>>> int cpu = smp_processor_id();
>>> struct rdt_resource *r;
>>> - struct rdt_domain *d;
>>> + struct rdt_mondomain *d;
>>
>> Reverse fir (Please check all code).
>
> Fixed. (I wrote a simple awk script to find these (as I'm
> obviously bad at noticing them). Included at end of this
> message).

Thank you very much for sharing your script.


Reinette

\
 
 \ /
  Last update: 2023-09-28 20:51    [W:0.194 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site