Messages in this thread Patch in this message | | | From | Christophe Leroy <> | Subject | Re: [PATCH v1 1/1] ARM: Select DMA_DIRECT_REMAP to fix restricted DMA | Date | Thu, 28 Sep 2023 16:24:16 +0000 |
| |
Hi,
For the form,
Le 26/09/2023 à 19:52, Jim Quinlan a écrit : > Without this commit, the use of dma_alloc_coherent() while
Instead, say "Without selecting DMA_DIRECT_REMAP, the use of ...."
> using CONFIG_DMA_RESTRICTED_POOL=y breaks devices from working. > For example, the common Wifi 7260 chip (iwlwifi) works fine > on arm64 with restricted memory but not on arm, unless this > commit is applied.
Say " .... unless DMA_DIRECT_REMAP is selected"
> > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> > --- > arch/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 9557808e8937..b6f1cea923cf 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -34,6 +34,7 @@ config ARM > select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT if CPU_V7 > select ARCH_SUPPORTS_ATOMIC_RMW > select ARCH_SUPPORTS_HUGETLBFS if ARM_LPAE > + select DMA_DIRECT_REMAP
On powerpc we try to keep those in alphabetical order. Don't you do the same on ARM ?
> select ARCH_USE_BUILTIN_BSWAP > select ARCH_USE_CMPXCHG_LOCKREF > select ARCH_USE_MEMTEST
| |