lkml.org 
[lkml]   [2023]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 20/27] platform/x86/intel: bytcrc_pwrsrc: Convert to platform remove callback returning void
    Date
    The .remove() callback for a platform driver returns an int which makes
    many driver authors wrongly assume it's possible to do error handling by
    returning an error code. However the value returned is ignored (apart
    from emitting a warning) and this typically results in resource leaks.

    To improve here there is a quest to make the remove callback return
    void. In the first step of this quest all drivers are converted to
    .remove_new(), which already returns void. Eventually after all drivers
    are converted, .remove_new() will be renamed to .remove().

    Trivially convert this driver from always returning zero in the remove
    callback to the void returning variant.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    ---
    drivers/platform/x86/intel/bytcrc_pwrsrc.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/platform/x86/intel/bytcrc_pwrsrc.c b/drivers/platform/x86/intel/bytcrc_pwrsrc.c
    index 8a022b90d12d..418b71af27ff 100644
    --- a/drivers/platform/x86/intel/bytcrc_pwrsrc.c
    +++ b/drivers/platform/x86/intel/bytcrc_pwrsrc.c
    @@ -158,17 +158,16 @@ static int crc_pwrsrc_probe(struct platform_device *pdev)
    return 0;
    }

    -static int crc_pwrsrc_remove(struct platform_device *pdev)
    +static void crc_pwrsrc_remove(struct platform_device *pdev)
    {
    struct crc_pwrsrc_data *data = platform_get_drvdata(pdev);

    debugfs_remove_recursive(data->debug_dentry);
    - return 0;
    }

    static struct platform_driver crc_pwrsrc_driver = {
    .probe = crc_pwrsrc_probe,
    - .remove = crc_pwrsrc_remove,
    + .remove_new = crc_pwrsrc_remove,
    .driver = {
    .name = "crystal_cove_pwrsrc",
    },
    --
    2.40.1
    \
     
     \ /
      Last update: 2023-09-27 18:54    [W:5.447 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site