Messages in this thread | | | Date | Wed, 27 Sep 2023 09:47:31 -0400 | Subject | Re: [PATCH v2 1/3] perf vendor events intel: Fix broadwellde tma_info_system_dram_bw_use metric | From | "Liang, Kan" <> |
| |
On 2023-09-26 4:59 p.m., Ian Rogers wrote: > Broadwell-de has a consumer core and server uncore. The uncore_arb PMU > isn't present and the broadwellx style cbox PMU should be used > instead. Fix the tma_info_system_dram_bw_use metric to use the server > metric rather than client. > > The associated converter script fix is in: > https://github.com/intel/perfmon/pull/111 > > Fixes: 7d124303d620 ("perf vendor events intel: Update broadwell variant events/metrics") > Signed-off-by: Ian Rogers <irogers@google.com> > ---
Thanks Ian. The whole patch series looks good to me.
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks, Kan
> tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json b/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json > index 8fc62b8f667d..d0ef46c9bb61 100644 > --- a/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json > +++ b/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json > @@ -652,7 +652,7 @@ > }, > { > "BriefDescription": "Average external Memory Bandwidth Use for reads and writes [GB / sec]", > - "MetricExpr": "64 * (arb@event\\=0x81\\,umask\\=0x1@ + arb@event\\=0x84\\,umask\\=0x1@) / 1e6 / duration_time / 1e3", > + "MetricExpr": "64 * (UNC_M_CAS_COUNT.RD + UNC_M_CAS_COUNT.WR) / 1e9 / duration_time", > "MetricGroup": "HPC;Mem;MemoryBW;SoC;tma_issueBW", > "MetricName": "tma_info_system_dram_bw_use", > "PublicDescription": "Average external Memory Bandwidth Use for reads and writes [GB / sec]. Related metrics: tma_fb_full, tma_mem_bandwidth, tma_sq_full"
| |