lkml.org 
[lkml]   [2023]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v5 10/11] iommu/vt-d: Add nested domain allocation
    Date
    > From: Liu, Yi L <yi.l.liu@intel.com>
    > Sent: Thursday, September 21, 2023 3:55 PM
    >
    >
    > + if (hwpt_type != IOMMU_HWPT_TYPE_DEFAULT &&
    > + hwpt_type != IOMMU_HWPT_TYPE_VTD_S1)
    > + return ERR_PTR(-EINVAL);
    > +
    > + if ((hwpt_type == IOMMU_HWPT_TYPE_DEFAULT) == !!parent)
    > + return ERR_PTR(-EINVAL);

    this is probably too strict. What about intel-iommu driver supports a
    IOMMU_HWPT_TYPE_VTD_S2 later for some tweak w/o nesting?

    let's make the parent match specific to VTD_S1 type.

    > +
    > + if (parent && request_nest_parent)
    > + return ERR_PTR(-EINVAL);

    this check should be moved to iommufd?

    \
     
     \ /
      Last update: 2023-09-27 18:53    [W:6.469 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site