Messages in this thread | | | Date | Wed, 27 Sep 2023 21:55:57 +0530 | Subject | Re: [PATCH 1/1] drm/amdkfd: Fix unaligned doorbell absolute offset for gfx8 | From | "Yadav, Arvind" <> |
| |
Adding Felix.Kuehling@amd.com for review.
Thanks ~Arvind
On 9/27/2023 9:46 PM, Arvind Yadav wrote: > This patch is to adjust the absolute doorbell offset > against the doorbell id considering the doorbell > size of 32/64 bit. > > Cc: Christian Koenig <christian.koenig@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Signed-off-by: Shashank Sharma <shashank.sharma@amd.com> > Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com> > --- > drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c > index 0d3d538b64eb..c327f7f604d7 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c > @@ -407,7 +407,16 @@ static int allocate_doorbell(struct qcm_process_device *qpd, > > q->properties.doorbell_off = amdgpu_doorbell_index_on_bar(dev->adev, > qpd->proc_doorbells, > - q->doorbell_id); > + 0); > + > + /* Adjust the absolute doorbell offset against the doorbell id considering > + * the doorbell size of 32/64 bit. > + */ > + if (!KFD_IS_SOC15(dev)) > + q->properties.doorbell_off += q->doorbell_id; > + else > + q->properties.doorbell_off += q->doorbell_id * 2; > + > return 0; > } >
| |