lkml.org 
[lkml]   [2023]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vidio: Clean up errors in serial.h
On Wed, Sep 27, 2023 at 02:32:23PM +0800, chenguohua@jari.cn wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>

Your subject line is very odd.

> ---
> include/linux/amba/clcd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/amba/clcd.h b/include/linux/amba/clcd.h
> index b6e0cbeaf533..64df8235d9cc 100644
> --- a/include/linux/amba/clcd.h
> +++ b/include/linux/amba/clcd.h
> @@ -244,7 +244,7 @@ static inline int clcdfb_check(struct clcd_fb *fb, struct fb_var_screeninfo *var
> var->xres_virtual = var->xres = (var->xres + 15) & ~15;
> var->yres_virtual = var->yres = (var->yres + 1) & ~1;
>
> -#define CHECK(e,l,h) (var->e < l || var->e > h)
> +#define CHECK(e, l, h) (var->e < l || var->e > h)

There is nothing wrong with the original code here, please do not run
checkpatch on code that is NOT in drivers/staging/ unless you get the
approval of the maintainer to do so.

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-09-27 18:53    [W:0.032 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site