Messages in this thread | | | Date | Tue, 26 Sep 2023 20:17:29 -0700 | From | Dan Williams <> | Subject | Re: [PATCH v4 2/6] configfs-tsm: Introduce a shared ABI for attestation reports |
| |
Kuppuswamy Sathyanarayanan wrote: [..] > >>> +/** > >>> + * struct tsm_desc - option descriptor for generating tsm report blobs > >>> + * @privlevel: optional privilege level to associate with @outblob > >>> + * @inblob_len: sizeof @inblob > >>> + * @inblob: arbitrary input data > >>> + */ > >>> +struct tsm_desc { > >>> + unsigned int privlevel; > >>> + size_t inblob_len; > >>> + u8 inblob[TSM_INBLOB_MAX]; > >>> +}; > >>> + > >>> +/** > >>> + * struct tsm_report - track state of report generation relative to options > >>> + * @desc: report generation options / cached report state > >>> + * @outblob: generated evidence to provider to the attestation agent > >>> + * @outblob_len: sizeof(outblob) > >> > >> I think following is incorrect. You might want to add info about certs_len > >> and certs. > > > > Yeah, missed updating this with certs addition. The outblob_len > > definition is correct, or do you mean the kdoc is out of order with > > respect to the struct? > > No, I am talking about the write_generation, read_generation and cfg options. > They are part of struct tsm_report_state, so why document it here?
Ah yup, will fix.
| |