lkml.org 
[lkml]   [2023]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v7 01/12] ext4: make state in ext4_mb_mark_bb to be bool
From
Date


on 9/27/2023 2:10 PM, Ritesh Harjani wrote:
> Kemeng Shi <shikemeng@huaweicloud.com> writes:
>
>> As state could only be either 0 or 1, just make it bool.
>
> Sure.
>
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>> ---
>> fs/ext4/ext4.h | 2 +-
>> fs/ext4/fast_commit.c | 8 ++++----
>> fs/ext4/mballoc.c | 2 +-
>> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> But why not convert at all places?
Sorry for this. Will convert at all places in next version. Thanks.
>
> git grep "ext4_mb_mark_bb" .
> fs/ext4/ext4.h:extern void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
> fs/ext4/extents.c: ext4_mb_mark_bb(inode->i_sb,
> fs/ext4/extents.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb,
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk,
> fs/ext4/mballoc.c:void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
> fs/ext4/mballoc.c: ext4_mb_mark_bb(sb, block, 1, 1);
>
> -ritesh
>

\
 
 \ /
  Last update: 2023-09-27 18:52    [W:0.043 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site