lkml.org 
[lkml]   [2023]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE_FLUSH for Micron eMMC Q2J54A
From
Date
On Fri, 2023-09-22 at 19:01 +0200, Francesco Dolcini wrote:
> > +
> > +                       if (host->card->quirks &
> > MMC_QUIRK_BROKEN_CACHE_FLUSH &&
> > +                           !host->card->written_flag && !ret)
> > +                               host->card->written_flag = true;
>
> From what I can see this branch is followed for both REQ_OP_READ and
> REQ_OP_WRITE, and I would say we want to set this flag only for
> REQ_OP_WRITE.
>
> Am I wrong?
>
> Francesco

you are right, we only care about write, I will update it in the next
version, thanks for your review!

Kind regards,
Bean
\
 
 \ /
  Last update: 2023-09-27 18:51    [W:5.852 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site