lkml.org 
[lkml]   [2023]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [External] Re: [PATCH] i2c: aspeed: Fix i2c bus hang in slave read
Date
Hi Joel / Jian,

Sorry ~ I didn't observe the last mail from Jian.

My last patch was used to avoid the situation like below link.
https://lists.ozlabs.org/pipermail/openbmc/2023-August/033756.html

Because I have applied controller reset in my patch.
Therefore, I think you just need to reset the slave state by "bus->slave_state = ASPEED_I2C_SLAVE_INACTIVE" in your case.

BR,

by Tommy

> -----Original Message-----
> From: Joel Stanley <joel@jms.id.au>
> Sent: Wednesday, September 27, 2023 10:43 AM
> To: Jian Zhang <zhangjian.3032@bytedance.com>
> Cc: Tommy Huang <tommy_huang@aspeedtech.com>;
> brendan.higgins@linux.dev; benh@kernel.crashing.org; andrew@aj.id.au;
> zhangjian3032@gmail.com; yulei.sh@bytedance.com;
> xiexinnan@bytedance.com; open list:ARM/ASPEED I2C DRIVER
> <linux-i2c@vger.kernel.org>; moderated list:ARM/ASPEED I2C DRIVER
> <openbmc@lists.ozlabs.org>; moderated list:ARM/ASPEED MACHINE SUPPORT
> <linux-arm-kernel@lists.infradead.org>; moderated list:ARM/ASPEED
> MACHINE SUPPORT <linux-aspeed@lists.ozlabs.org>; open list
> <linux-kernel@vger.kernel.org>
> Subject: Re: [External] Re: [PATCH] i2c: aspeed: Fix i2c bus hang in slave read
>
> On Fri, 22 Sept 2023 at 14:39, Jian Zhang <zhangjian.3032@bytedance.com>
> wrote:
> > >
> > > Tommy has submitted a similar fix:
> > >
> > >
> > > https://lore.kernel.org/linux-i2c/20230906004910.4157305-1-tommy_hua
> > > ng@aspeedtech.com/
> > >
> > > His change is very heavy handed; it reinitialises the bus including
> > > re-parsing the device tree (!).
> > >
> > > Should we have merged this fix instead? If not, are you able to
> > > confirm that his change fixes your issue?
> >
> > I feel it's for solving the same issue, but I think this patch is
> > missing the action `bus->slave_state = ASPEED_I2C_SLAVE_INACTIVE;`,
> > which means it can't resolve my problem. @Tommy, can you help confirm
> this?
>
> You're right, it doesn't change the slave_state at all.
>
> Unfortunately, despite no acks from the maintainers, this patch has now been
> merged and backported to stable. We should complete the fix, or revert it
> asap.
\
 
 \ /
  Last update: 2023-09-27 18:51    [W:0.066 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site