Messages in this thread | | | Date | Wed, 27 Sep 2023 15:20:14 -0700 | Subject | Re: [PATCH v10 01/10] x86/resctrl: Add multiple tasks to the resctrl group at once | From | Reinette Chatre <> |
| |
Hi Babu,
On 9/27/2023 2:44 PM, Moger, Babu wrote: > On 9/27/2023 1:30 PM, Reinette Chatre wrote: >> On 9/15/2023 3:42 PM, Babu Moger wrote: >>> The resctrl task assignment for monitor or control group needs to be >>> done one at a time. For example: >>> >>> $mount -t resctrl resctrl /sys/fs/resctrl/ >>> $mkdir /sys/fs/resctrl/ctrl_grp1 >>> $echo 123 > /sys/fs/resctrl/ctrl_grp1/tasks >>> $echo 456 > /sys/fs/resctrl/ctrl_grp1/tasks >>> $echo 789 > /sys/fs/resctrl/ctrl_grp1/tasks >>> >>> This is not user-friendly when dealing with hundreds of tasks. >>> >>> Support multiple task assignment in one command with tasks ids separated >>> by commas. For example: >>> $echo 123,456,789 > /sys/fs/resctrl/ctrl_grp1/tasks >>> >>> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com> >>> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com> >>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> >>> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com> >>> Signed-off-by: Babu Moger <babu.moger@amd.com> >> x86 area aims to have a uniform view of commit tags. >> Please review the "Ordering of commit tags" section within >> Documentation/process/maintainer-tip.rst and apply that >> custom to this whole series. > > After reading it, it appears this should be the order. starting with Author SOB. Hope this is what you meant. > > Signed-off-by: Babu Moger <babu.moger@amd.com> > Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com> > Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com> > Reviewed-by: Fenghua Yu <fenghua.yu@intel.com> > Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> >
This matches my interpretation.
Reinette
| |