lkml.org 
[lkml]   [2023]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode
From
On 27.09.23 02:39, Stefan Roesch wrote:
>
> Andrew Morton <akpm@linux-foundation.org> writes:
>
>> On Tue, 26 Sep 2023 09:13:31 -0700 Stefan Roesch <shr@devkernel.io> wrote:
>>
>>>> Thinking about it, what are the cons of just enabling this always and not
>>>> exposing new toggles? Alternatively, we could make this a compile-time option.
>>>>
>>>> In general, LGTM, just curious if we really have to make this configurable.
>>>>
>>>
>>> The only downside I can see is that it might take a longer time for some
>>> pages to be de-duplicated (a new candidate page is added, but its
>>> duplicate is skipped in this round). So it will take longer to
>>> de-duplicate this page.
>>>
>>> I tested with more than one workload, but it might be useful to get some
>>> data with additional workloads. I was thinking of enabling it after one or
>>> two releases.
>>
>> We could keep the tunable and make it default "on"?
>
> Sounds good to me
>

+1

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Cheers,

David / dhildenb

\
 
 \ /
  Last update: 2023-09-27 18:54    [W:0.348 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site