Messages in this thread | | | Subject | Re: [PATCH] ima: rework CONFIG_IMA dependency block | From | Mimi Zohar <> | Date | Wed, 27 Sep 2023 06:52:26 -0400 |
| |
On Wed, 2023-09-27 at 09:22 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Changing the direct dependencies of IMA_BLACKLIST_KEYRING and > IMA_LOAD_X509 caused them to no longer depend on IMA, but a > a configuration without IMA results in link failures: > > arm-linux-gnueabi-ld: security/integrity/iint.o: in function `integrity_load_keys': > iint.c:(.init.text+0xd8): undefined reference to `ima_load_x509' > > aarch64-linux-ld: security/integrity/digsig_asymmetric.o: in function `asymmetric_verify': > digsig_asymmetric.c:(.text+0x104): undefined reference to `ima_blacklist_keyring' > > Adding explicit dependencies on IMA would fix this, but a more reliable > way to do this is to enclose the entire Kconfig file in an 'if IMA' block. > This also allows removing the existing direct dependencies. > > Fixes: be210c6d3597f ("ima: Finish deprecation of IMA_TRUSTED_KEYRING Kconfig") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Oleksandr Tymoshenko's patch to address this, made it into linux-next today.
Commit be210c6d3597 ("ima: Finish deprecation of IMA_TRUSTED_KEYRING Kconfig") made it last night into linux-next.
-- thanks,
Mimi
| |