Messages in this thread | | | Date | Wed, 27 Sep 2023 17:05:10 +0800 | Subject | Re: [PATCH V2 2/2] gpio: pmic-eic-sprd: Add can_sleep flag for PMIC EIC chip | From | Baolin Wang <> |
| |
On 9/21/2023 8:25 PM, Wenhua Lin wrote: > The drivers uses a mutex and I2C bus access in its PMIC EIC chip > get implementation. This means these functions can sleep and the PMIC EIC > chip should set the can_sleep property to true. > > This will ensure that a warning is printed when trying to get the > value from a context that potentially can't sleep.
LGTM. Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com> > --- > drivers/gpio/gpio-pmic-eic-sprd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c > index 442968bb2490..f04a40288638 100644 > --- a/drivers/gpio/gpio-pmic-eic-sprd.c > +++ b/drivers/gpio/gpio-pmic-eic-sprd.c > @@ -353,6 +353,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev) > pmic_eic->chip.set_config = sprd_pmic_eic_set_config; > pmic_eic->chip.set = sprd_pmic_eic_set; > pmic_eic->chip.get = sprd_pmic_eic_get; > + pmic_eic->chip.can_sleep = true; > > irq = &pmic_eic->chip.irq; > gpio_irq_chip_set_chip(irq, &pmic_eic_irq_chip);
| |