lkml.org 
[lkml]   [2023]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] r8152: Retry register reads/writes
On Tue, Sep 26, 2023 at 02:27:27PM -0700, Douglas Anderson wrote:
> +
> +static
> +int r8152_control_msg(struct usb_device *udev, unsigned int pipe, __u8 request,
> + __u8 requesttype, __u16 value, __u16 index, void *data,
> + __u16 size, const char *msg_tag)
> +{
> + int i;
> + int ret;
> +
> + for (i = 0; i < REGISTER_ACCESS_TRIES; i++) {
> + ret = usb_control_msg(udev, pipe, request, requesttype,
> + value, index, data, size,
> + USB_CTRL_GET_TIMEOUT);
> +
> + /* No need to retry or spam errors if the USB device got
> + * unplugged; just return immediately.
> + */
> + if (udev->state == USB_STATE_NOTATTACHED)
> + return ret;

Rather than testing udev->state, it would be better to check whether
ret == -ENODEV. udev->state is meant primarily for use by the USB core
and it's subject to races.

Alan Stern

\
 
 \ /
  Last update: 2023-09-27 18:54    [W:0.065 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site