Messages in this thread | | | Subject | Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree | From | lukas walter <> | Date | Mon, 25 Sep 2023 16:28:12 +0200 |
| |
Date: Wed, 20 Sep 2023 16:47:30 +0200
>> + >> + reserved-memory { >> + reserved@84a00000 { >> + reg = <0x0 0x84a00000 0x0 0x1600000>; >> + no-map; >> + }; >Do we know what this is for?
This seems to be some QSEE/TrustZone memory required to boot. I would name it `qseecom_mem: qseecom@84a00000` like other phones currently have it.
`[ 1.162115] QSEECOM: qseecom_probe: secure app region addr=0x84a00000 size=0x1900000`
>> + }; >> + >> + gpio-hall-sensor { >> + compatible = "gpio-keys"; >> + >> + pinctrl-0 = <&gpio_hall_sensor_default>; >> + pinctrl-names = "default"; >> + >> + label = "GPIO Hall Effect Sensor"; >I think we can have both hall sensor and V+ under gpio-keys > >And then I am not sure how useful the label is for the container >node, maybe you or somebody else can tell me whether it's used >anywhere >> + >> + event-hall-sensor { >> + label = "Hall Effect Sensor"; >> + gpios = <&tlmm 69 GPIO_ACTIVE_LOW>; >> + linux,input-type = <EV_SW>; >> + linux,code = <SW_LID>; >> + linux,can-disable; >Should this not be a wakeup-source btw?
I am not sure how to change this. I would like to leave this as many other hall sensors seem to be configured identically.
Is this fine? Should I send a V2 with the signoff and reserved-memory changes?
| |