Messages in this thread | | | Date | Mon, 25 Sep 2023 10:30:44 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH RFC 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors |
| |
On Sun, Sep 24, 2023 at 06:42:54PM +0200, Duje Mihanović wrote: > Sharp's Spitz board still uses the legacy GPIO interface for controlling > a GPIO pin related to the USB host controller. > > Convert this function to use the new GPIO descriptor interface.
...
> + pxa_ohci->usb_host = gpiod_get(&pdev->dev, "usb-host", GPIOD_OUT_LOW); > + if (IS_ERR(pxa_ohci->usb_host)) { > + dev_warn(&pdev->dev, "failed to get USB host GPIO with %d\n", > + (int) pxa_ohci->usb_host);
Casting is no go in 99.9% cases in printf(), so use proper specifier. Hint: Nice looking message can be obtained by using %pe.
> + pxa_ohci->usb_host = NULL;
Instead, call for _optional() API.
> + }
...
> + if (pxa_ohci->usb_host) > + gpiod_put(pxa_ohci->usb_host);
Linus, Bart, do we have misdesigned _optinal() GPIO APIs?
In GPIOLIB=n, the above requires that redundant check. Shouldn't we replace gpiod_put() stub to be simply no-op?
-- With Best Regards, Andy Shevchenko
| |