lkml.org 
[lkml]   [2023]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v13 3/7] arm64: smp: Remove dedicated wakeup IPI
Mark,

On Wed, Sep 6, 2023 at 9:06 AM Douglas Anderson <dianders@chromium.org> wrote:
>
> +#ifdef CONFIG_ARM64_ACPI_PARKING_PROTOCOL
> +void arch_send_wakeup_ipi(unsigned int cpu)
> +{
> + /*
> + * We use a scheduler IPI to wake the CPU as this avoids the need for a
> + * dedicated IPI and we can safely handle spurious scheduler IPIs.
> + */
> + arch_smp_send_reschedule(cpu);

I was backporting this to our ChromeOS kernels and our build test bot
noticed that arch_smp_send_reschedule() didn't exist in older kernels.
That's fine--I can always adjust this patch when backporting or
cherry-pick extra patches, but it made me wonder. Is there a reason
you chose to use arch_smp_send_reschedule() directly here instead of
smp_send_reschedule()? I guess the only difference is that you're
bypassing the tracing. Is that on purpose? Should we add a comment
about it, or change this to smp_send_reschedule()?

Thanks!

-Doug

\
 
 \ /
  Last update: 2023-09-26 02:41    [W:0.142 / U:1.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site