lkml.org 
[lkml]   [2023]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 6/9] platform/x86/intel/ifs: Metadata validation for start_chunk
    From


    On 9/25/2023 8:45 AM, Ilpo Järvinen wrote:
    > On Fri, 22 Sep 2023, Jithu Joseph wrote:
    >
    >> Add an additional check to validate IFS image metadata field prior to
    >> loading the test image.
    >>
    >> If start_chunk is not a multiple of chunks_per_stride error out.
    >>
    >> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
    >> Reviewed-by: Tony Luck <tony.luck@intel.com>
    >> Tested-by: Pengfei Xu <pengfei.xu@intel.com>
    >> ---
    >> drivers/platform/x86/intel/ifs/load.c | 7 +++++++
    >> 1 file changed, 7 insertions(+)
    >>
    >> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
    >> index b09106034fac..c92d313b921f 100644
    >> --- a/drivers/platform/x86/intel/ifs/load.c
    >> +++ b/drivers/platform/x86/intel/ifs/load.c
    >> @@ -291,6 +291,13 @@ static int validate_ifs_metadata(struct device *dev)
    >> return ret;
    >> }
    >>
    >> + if (ifs_meta->chunks_per_stride != 0 &&
    >> + (ifs_meta->starting_chunk % ifs_meta->chunks_per_stride)) {
    >
    > I meant that != 0 should be on the second line.
    >

    Ah I see ... Will change

    Jithu

    \
     
     \ /
      Last update: 2023-09-25 20:26    [W:2.452 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site