Messages in this thread | | | Date | Mon, 25 Sep 2023 11:04:32 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] dm crypt: replace open-coded kmemdup_nul |
| |
On Mon, Sep 25, 2023 at 06:35:54AM +0000, Justin Stitt wrote: > kzalloc() followed by strncpy() on an expected NUL-terminated string is > just kmemdup_nul(). Let's simplify this code (while also dropping a > deprecated strncpy() call [1]). > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Cc: Kees Cook <keescook@chromium.org> > Signed-off-by: Justin Stitt <justinstitt@google.com>
This looks correct to me. Thanks!
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |