Messages in this thread | | | Date | Mon, 25 Sep 2023 09:59:22 -0700 | Subject | Re: [PATCH] ice: require PTP clock for building | From | Tony Nguyen <> |
| |
On 9/25/2023 8:55 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > A previous fix added PTP as an optional dependency, which was correct as > of commit 87758511075ec ("igc: fix build errors for PTP"), but this > has recently changed with the PTP code getting more deeply integrated > into the ICE driver. > > Trying to build ICE when PTP is disabled results in this internal link failure > as the local functions are left out of the driver: > > ERROR: modpost: "ice_is_clock_mux_present_e810t" [drivers/net/ethernet/intel/ice/ice.ko] undefined! > ERROR: modpost: "ice_is_phy_rclk_present" [drivers/net/ethernet/intel/ice/ice.ko] undefined! > ERROR: modpost: "ice_cgu_get_pin_name" [drivers/net/ethernet/intel/ice/ice.ko] undefined! > ERROR: modpost: "ice_get_cgu_state" [drivers/net/ethernet/intel/ice/ice.ko] undefined! > ERROR: modpost: "ice_is_cgu_present" [drivers/net/ethernet/intel/ice/ice.ko] undefined! > ERROR: modpost: "ice_get_cgu_rclk_pin_info" [drivers/net/ethernet/intel/ice/ice.ko] undefined! > ERROR: modpost: "ice_cgu_get_pin_type" [drivers/net/ethernet/intel/ice/ice.ko] undefined! > ERROR: modpost: "ice_cgu_get_pin_freq_supp" [drivers/net/ethernet/intel/ice/ice.ko] undefined! > > I tried rearranging the code to allow building it again, but this was getting > too complicated for an outsider, so just enforce the dependency to fix randconfig > builds again, until someone wants to clean this up again.
Hi Arnd,
There's a pending patch to netdev that does this [1].
Thanks, Tony
> In practice, any configuration that includes this driver is also going to > want PTP clocks anyway. > > Fixes: 8a3a565ff210a ("ice: add admin commands to access cgu configuration") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[1] https://lore.kernel.org/netdev/20230921000633.1238097-1-jacob.e.keller@intel.com/
| |