lkml.org 
[lkml]   [2023]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 19/19] staging: iio: resolver: ad2s1210: add triggered buffer support
    On Sun, Sep 24, 2023 at 1:17 PM Jonathan Cameron <jic23@kernel.org> wrote:
    >
    > On Thu, 21 Sep 2023 09:44:00 -0500
    > David Lechner <dlechner@baylibre.com> wrote:
    >
    ...
    > > + /* REVIST: we can read 3 bytes here and also get fault flags */
    >
    > Given we have fault detection outputs, does it make sense to do so?
    > Or should we just rely on those triggering an interrupt?
    >
    > > + ret = spi_read(st->sdev, st->rx, 2);
    >

    I'm thinking the former would be better, but I have a pending inquiry with ADI
    to get more info on this since the fault pins and/or fault registers
    don't seem to
    be working quite like the datasheet says they should (I am seeing fault bits set
    in the register without the fault pins being asserted).

    \
     
     \ /
      Last update: 2023-09-25 18:51    [W:4.911 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site